On Fri, Apr 01, 2022 at 11:48:04AM +0200, Horatiu Vultur wrote: > Based on the discussions here[1], the PHY driver is the wrong place > to set the latencies, therefore remove them. > > [1] https://lkml.org/lkml/2022/3/4/325 > > Fixes: ece19502834d84 ("net: phy: micrel: 1588 support for LAN8814 phy") > Signed-off-by: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx> Thanks for the revert. Reviewed-by: Andrew Lunn <andrew@xxxxxxx> > -static struct kszphy_latencies lan8814_latencies = { > - .rx_10 = 0x22AA, > - .tx_10 = 0x2E4A, > - .rx_100 = 0x092A, > - .tx_100 = 0x02C1, > - .rx_1000 = 0x01AD, > - .tx_1000 = 0x00C9, > -}; What are the reset defaults of these? I'm just wondering if we should explicitly set them to 0, so we don't get into a mess where some vendor bootloader sets values but mainline bootloader does not, breaking a configuration where the userspace daemon does the correct? Andrew
