Re: [PATCH 4/5] ARM: dts: BCM5301X: Retrieve gmac1 MAC address from NVRAM on Asus RT-AC88U

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2022-04-01 12:20, Arınç ÜNAL wrote:
The et1macaddr NVRAM variable contains a MAC address for gmac1 on Asus
RT-AC88U. Add NVMEM cell for it and reference it in the gmac1 node.

The Broadcom GBit BCMA driver will issue the MAC address for gmac{0,1,2} retrieved from et{0,1,2}mac from SPROM without this but let's explicitly
define it as mac-address on the devicetree.
Refer to drivers/net/ethernet/broadcom/bgmac-bcma.c:147.

It doesn't matter how Linux handles that in details. You're working on
hardware binding.

Change is OK of course.

If you need to reference sth it should be
Documentation/devicetree/bindings/net/ethernet-controller.yaml


Signed-off-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>

I'd drop bgmac-bcma.c reference but nevertheless:

Acked-by: Rafał Miłecki <rafal@xxxxxxxxxx>



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux