On Fri, 1 Apr 2022 at 11:22, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > > On Tue, 29 Mar 2022 at 05:29, Axe Yang <axe.yang@xxxxxxxxxxxx> wrote: > > > > Extend interrupts and pinctrls for SDIO wakeup interrupt feature. > > This feature allow SDIO devices alarm asynchronous interrupt to host > > even when host stop providing clock to SDIO card. An extra wakeup > > interrupt and pinctrl states for SDIO DAT1 pin state switching are > > required in this scenario. > > > > Signed-off-by: Axe Yang <axe.yang@xxxxxxxxxxxx> > > --- > > .../devicetree/bindings/mmc/mtk-sd.yaml | 17 ++++++++++++++++- > > 1 file changed, 16 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > index 297ada03e3de..3872a6ce2867 100644 > > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > @@ -69,12 +69,22 @@ properties: > > - const: ahb_cg > > > > interrupts: > > - maxItems: 1 > > + description: > > + Should at least contain MSDC GIC interrupt. To support SDIO in-band wakeup, an extended > > + interrupt is required and be configured as wakeup source irq. > > If I understand correctly, the extended interrupt (a GPIO irq) may not > necessarily share the same interrupt parent as the primary device > interrupt. > > Perhaps it's then better to extend this with "interrupts-extended" > instead. See Documentation/devicetree/bindings/interrupt-controller/interrupts.txt. One more thing, looks like using the "interrupt-names" property would be good to use too. To easier distinguish the different irqs. [...] Kind regards Uffe
