> On Thu, Mar 31, 2022 at 10:29 AM Qin Jian <qinjian@xxxxxxxxxxx> wrote:
> > Add generic Sunplus SP7021 based board defconfig
>
> Here, you should explain why you need a custom defconfig for this SoC, as
> most platforms are fine just using the generic one. Are you too memory
> constrained,
> or are there other problems?
>
For memory constrained board only.
> > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> > index 8863fa969..a3bd9dbd8 100644
> > --- a/arch/arm/configs/multi_v7_defconfig
> > +++ b/arch/arm/configs/multi_v7_defconfig
> > @@ -86,6 +86,7 @@ CONFIG_MACH_SPEAR1310=y
> > CONFIG_MACH_SPEAR1340=y
> > CONFIG_ARCH_STI=y
> > CONFIG_ARCH_STM32=y
> > +CONFIG_ARCH_SUNPLUS=y
> > CONFIG_ARCH_SUNXI=y
> > CONFIG_ARCH_TEGRA=y
> > CONFIG_ARCH_UNIPHIER=y
>
> Don't you need any drivers here?
>
Currently, all basic drivers auto enabled by mach-sunplus/Kconfig:
...
config SOC_SP7021
bool "Sunplus SP7021 SoC support"
depends on ARCH_SUNPLUS
default ARCH_SUNPLUS
select ARM_GIC
select ARM_PSCI
select PINCTRL
select PINCTRL_SPPCTL
select SERIAL_SUNPLUS
select SERIAL_SUNPLUS_CONSOLE
and driver's Kconfig:
...
config RESET_SUNPLUS
bool "Sunplus SoCs Reset Driver" if COMPILE_TEST
default ARCH_SUNPLUS
...
> > diff --git a/arch/arm/configs/sp7021_defconfig b/arch/arm/configs/sp7021_defconfig
> > new file mode 100644
> > index 000000000..cda16d33a
> > --- /dev/null
> > +++ b/arch/arm/configs/sp7021_defconfig
> ...
> > +CONFIG_HAVE_ARM_ARCH_TIMER=y
>
> I checked this one again, as most others don't enable it in the defconfig.
>
> I don't remember if I recommended removing the 'select' from Kconfig
> in a previous round, but as that is where other platforms have it, I'd add
> it there as well.
>
I'll move this to mach-sunplus/Kconfig.
> > +CONFIG_STAGING=y
>
> Do you actually enable any staging drivers here? If not, I'd drop that bit.
>
I’ll drop it.
Thanks all your comments.
