Am 2022-03-31 18:28, schrieb Andrew Lunn:
@@ -295,21 +323,41 @@ static int mscc_miim_probe(struct
platform_device *pdev)
if (!miim->info)
return -EINVAL;
- ret = of_mdiobus_register(bus, pdev->dev.of_node);
+ miim->clk = devm_clk_get_optional(&pdev->dev, NULL);
+ if (IS_ERR(miim->clk))
+ return PTR_ERR(miim->clk);
+
+ ret = clk_prepare_enable(miim->clk);
+ if (ret)
+ return ret;
+
+ of_property_read_u32(np, "clock-frequency", &miim->clk_freq);
The clock is optional if there is no "clock-frequency" property. If
the property does exist, the clock should be mandatory. I don't think
it should silently fail setting the bus frequency because the clock is
missing.
Oh yes, agreed.
-michael
