On Fri, Apr 01, 2022 at 05:49:11AM +0800, niravkumar.l.rabara@xxxxxxxxx wrote: > --- > .../bindings/misc/altera-hwmutex.yaml | 47 +++ > drivers/misc/Kconfig | 6 + > drivers/misc/Makefile | 1 + > drivers/misc/altera_hwmutex.c | 321 ++++++++++++++++++ > include/linux/altera_hwmutex.h | 42 +++ There is no need for a .h file for a single .c file. Please fix that up for your next submission. I don't think I need to read anymore :) thanks, greg k-h