Re: [PATCH v2] arm64: dts: renesas: rzg2lc-smarc: Enable RSPI1 on carrier board

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Biju,

On Mon, Mar 21, 2022 at 2:56 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> RSPI1 (SPI1) interface is available on PMOD0 connector (J1) on the
> carrier board.  This patch adds pinmux and spi1 nodes to the carrier
> board dtsi file and drops deleting pinctl* properties from DTS file.
>
> RSPI1 interface is tested by setting the macro SW_RSPI_CAN to 0.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> ---
> v1->v2:
>  * Sorted the node alphabetically
>  * Delete/disable pinctrl/spi node, when SW_RSPI_CAN macro is set to 1.
>    This change is done in common file, so that both single core and
>    dual core RZ/G2LC SMARC EVK can reuse the same.

Thanks for the update!

> --- a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> @@ -158,3 +158,17 @@
>         status = "okay";
>  };
>  #endif
> +
> +#if (!SW_RSPI_CAN)
> +&spi1 {
> +       pinctrl-0 = <&spi1_pins>;
> +       pinctrl-names = "default";
> +       status = "okay";
> +};

Unless I'm missing something, the above is overriding properties in
the spi1 node in rz-smarc-common.dtsi with the exact same values they
already have?

So I think this branch can be removed, and only the #else below
should be kept.

> +#else
> +&spi1 {
> +       /delete-property/ pinctrl-0;
> +       /delete-property/ pinctrl-names;
> +       status = "disabled";
> +};
> +#endif

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux