Hi Biju, On Tue, Mar 15, 2022 at 4:59 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > Enable the microSD card slot connected to SDHI1 on the RZ/G2UL SMARC > platform by removing the sdhi1 override which disabled it, and by adding > the necessary pinmux required for SDHI1. > > This patch also overrides vqmmc-supply for SDHI1. > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> Thanks for your patch! > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi > @@ -0,0 +1,27 @@ > +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +/* > + * Device Tree Source for the RZ/G2UL Type-1 SMARC EVK parts > + * > + * Copyright (C) 2022 Renesas Electronics Corp. > + */ > + > +#include "rzg2ul-smarc-som.dtsi" > +#include "rzg2ul-smarc-pinfunction.dtsi" > +#include "rz-smarc-common.dtsi" > + > +/ { > + vccq_sdhi1: regulator-vccq-sdhi1 { > + compatible = "regulator-gpio"; > + regulator-name = "SDHI1 VccQ"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > + gpios = <&pinctrl RZG2L_GPIO(6, 1) GPIO_ACTIVE_HIGH>; > + gpios-states = <1>; > + states = <3300000 1>, <1800000 0>; > + }; This regulator is already defined in rz-smarc-common.dtsi, which is included above? That definition does use a different gpios property, though. > +}; > + > +&sdhi1 { > + vqmmc-supply = <&vccq_sdhi1>; > +}; > + Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds