> On 31. 3. 2022, at 14:08, Martin Povišer <povik@xxxxxxxxxxx> wrote: > >> >> On 31. 3. 2022, at 13:59, Mark Brown <broonie@xxxxxxxxxx> wrote: >> >> On Thu, Mar 31, 2022 at 02:04:49AM +0200, Martin Povišer wrote: >> >>> --- /dev/null >>> +++ b/sound/soc/apple/macaudio.c >>> @@ -0,0 +1,597 @@ >>> +// SPDX-License-Identifier: GPL-2.0-only >>> +/* >>> + * ASoC machine driver for Apple Silicon Macs >>> + * (snip) >>> +/* >>> + * Maybe this could be a general ASoC function? >>> + */ >>> +static void snd_soc_kcontrol_set_strval(struct snd_soc_card *card, >>> + struct snd_kcontrol *kcontrol, const char *strvalue) >> >> No, we should not be setting user visible control values from the >> kernel. This shouldn't be a machine driver function either. What are >> you trying to accomplish here? > > See above. > > Martin One thing I didn’t point out. The controls we are setting here are not visible from userspace. That’s the point of the ‘filter’ card method I am trying to establish in the other commit. With it, the card decides which controls are okay to be exported and which should be hidden. Here we are only setting hidden controls. Martin
