Re: [PATCH v12 2/9] dt-bindings: reset: Add bindings for SP7021 reset driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 31, 2022 at 10:29 AM Qin Jian <qinjian@xxxxxxxxxxx> wrote:

> +/* mo_reset0 ~ mo_reset9 */
> +#define RST_SYSTEM             0x00
> +#define RST_RTC                        0x02
> +#define RST_IOCTL              0x03
> +#define RST_IOP                        0x04
> +#define RST_OTPRX              0x05
> +#define RST_NOC                        0x06
> +#define RST_BR                 0x07
> +#define RST_RBUS_L00           0x08
> +#define RST_SPIFL              0x09
> +#define RST_SDCTRL0            0x0a
> +#define RST_PERI0              0x0b
> +#define RST_A926               0x0d
> +#define RST_UMCTL2             0x0e
> +#define RST_PERI1              0x0f
> +
> +#define RST_DDR_PHY0           0x10
> +#define RST_ACHIP              0x12
> +#define RST_STC0               0x14
> +#define RST_STC_AV0            0x15
> +#define RST_STC_AV1            0x16
> +#define RST_STC_AV2            0x17

The list looks like these definitions just match the hardware, which means you
don't have to define them as a binding at all, just use the hardware numbers
directly in the dt, as you do for interrupts or gpio numbers.

If the hardware does not have a sane way of mapping reset lines to a particular
hardware number, then you may have to define a binding, but in that case just
use consecutive integer numbers, not hexadecimal numbers.

       Arnd



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux