Re: [PATCH v2 1/3] dt-bindings: net: smsc,lan91c111 convert to schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 29, 2022 at 4:35 PM Rui Miguel Silva <rui.silva@xxxxxxxxxx> wrote:
>
> Convert the smsc lan91c9x and lan91c1xx controller device tree
> bindings documentation to json-schema.
>
> Signed-off-by: Rui Miguel Silva <rui.silva@xxxxxxxxxx>
> ---
>  .../bindings/net/smsc,lan91c111.yaml          | 59 +++++++++++++++++++
>  1 file changed, 59 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/smsc,lan91c111.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/smsc,lan91c111.yaml b/Documentation/devicetree/bindings/net/smsc,lan91c111.yaml
> new file mode 100644
> index 000000000000..5976f4fa4a80
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/smsc,lan91c111.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/smsc,lan91c111.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Smart Mixed-Signal Connectivity (SMSC) LAN91C9x/91C1xx Controller
> +
> +maintainers:
> +  - Nicolas Pitre <nico@xxxxxxxxxxx>
> +
> +allOf:
> +  - $ref: ethernet-controller.yaml#
> +
> +properties:
> +  compatible:
> +    const: smsc,lan91c111
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  reg-shift: true
> +
> +  reg-io-width:
> +    enum: [ 1, 2, 4 ]
> +    default: 2
> +
> +  reset-gpios:
> +    description: GPIO connected to control RESET pin
> +    maxItems: 1
> +
> +  power-gpios:
> +    description: GPIO connect to control PWRDEWN pin
> +    maxItems: 1
> +
> +  pxa-u16-align4:
> +    description: put in place the workaround the force all u16 writes to be
> +      32 bits aligned
> +    type: boolean
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +additionalProperties: true

This is only allowed on incomplete, common schemas. Instead use:

unevaluatedProperties: false

As that allows for properties defined in ethernet-controller.yaml.

> +
> +examples:
> +  - |
> +    ethernet@4010000 {
> +          compatible = "smsc,lan91c111";
> +          reg = <0x40100000 0x10000>;
> +          phy-mode = "mii";
> +          interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>;
> +          reg-io-width = <2>;
> +    };
> --
> 2.35.1
>



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux