On Fri, Mar 25, 2022 at 10:23:32PM +0530, Prasanna Vengateshan wrote: > *-internal-delay-ps properties would be applicable only for RGMII interface > modes. > > It is changed as per the request, > https://lore.kernel.org/netdev/d8e5f6a8-a7e1-dabd-f4b4-ea8ea21d0a1d@xxxxxxxxx/ > > Ran dt_binding_check to confirm nothing is broken. > > Signed-off-by: Prasanna Vengateshan <prasanna.vengateshan@xxxxxxxxxxxxx> > Reviewed-by: Andrew Lunn <andrew@xxxxxxx> > --- > .../bindings/net/ethernet-controller.yaml | 37 +++++++++++++------ > 1 file changed, 25 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml > index 34c5463abcec..dc86a6479a86 100644 > --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml > +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml > @@ -123,12 +123,6 @@ properties: > and is useful for determining certain configuration settings > such as flow control thresholds. > > - rx-internal-delay-ps: > - description: | > - RGMII Receive Clock Delay defined in pico seconds. > - This is used for controllers that have configurable RX internal delays. > - If this property is present then the MAC applies the RX delay. > - > sfp: > $ref: /schemas/types.yaml#/definitions/phandle > description: > @@ -140,12 +134,6 @@ properties: > The size of the controller\'s transmit fifo in bytes. This > is used for components that can have configurable fifo sizes. > > - tx-internal-delay-ps: > - description: | > - RGMII Transmit Clock Delay defined in pico seconds. > - This is used for controllers that have configurable TX internal delays. > - If this property is present then the MAC applies the TX delay. > - > managed: > description: > Specifies the PHY management type. If auto is set and fixed-link > @@ -222,6 +210,31 @@ properties: > required: > - speed > > +allOf: > + - if: > + properties: > + phy-mode: > + contains: > + enum: > + - rgmii > + - rgmii-rxid > + - rgmii-txid > + - rgmii-id > + then: Did you test this? The 'then' has no effect. It's at the wrong indentation. It should be the same as 'if'. > + properties: > + rx-internal-delay-ps: > + description: > + RGMII Receive Clock Delay defined in pico seconds.This is > + used for controllers that have configurable RX internal > + delays. If this property is present then the MAC applies > + the RX delay. > + tx-internal-delay-ps: > + description: > + RGMII Transmit Clock Delay defined in pico seconds.This is > + used for controllers that have configurable TX internal > + delays. If this property is present then the MAC applies > + the TX delay. > + > additionalProperties: true > > ... > -- > 2.30.2 > >
