Re: [Patch v2 net-next 09/12] net: fec: change FEC alignment according to i.mx6 sx requirement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Wed, Sep 10, 2014 at 10:22 AM, Zhi Li <lznuaa@xxxxxxxxx> wrote:
> On Wed, Sep 10, 2014 at 7:51 AM, Fabio Estevam <festevam@xxxxxxxxx> wrote:
>> On Tue, Sep 9, 2014 at 5:15 PM, Frank Li <Frank.Li@xxxxxxxxxxxxx> wrote:
>>
>>> +       fep->rx_align = 0x3;
>>> +       fep->tx_align = 0x3;
>>
>> Why do you unconditionally set it as 0x3? It was 0xf for ARM and 0x3
>> for non-ARM.
>
> Will fix it at next version.

Also, please make sure to add Russell King on Cc in the next version.
He has recently done a lot of work in this driver.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux