On Sun, Mar 27, 2022 at 09:21:34PM +0200, Krzysztof Kozlowski wrote: > On 26/03/2022 22:21, Kuldeep Singh wrote: > > Qualcomm QSPI DT spec says interconnects has minimum length 1 and > > maximum length 2. Same configuration will be applicable for > > interconnect-names. Schema currently depicts interconnects length > > correctly but not interconnect-names. It can have a single entry, which > > is a valid case yet to be incorporated in the current configuration. The > > schema tries to look for 2 names and fail for DTs with a single entry. > > Thus, add minItems property to interconnect-names to fix it. > > Thanks for the patch. > > 6 sentences which explaining the same, which could be written in one > sentence. In the same time you actually do not explain whether having > one interconnect is correct. You just say what DT spec says about > interconnects, but maybe that's wrong. Though commit desscription is subject to personal perspective, but I also see some duplication here and will submit v2 with a shorter description. > > So either keep just one sentence or really explain why one or two are > allowed (based on datasheet for example). Please see commit 8f9c291558ea, interconnect properties were added by one of maintainers of qcom-qspi. And it's been sometime this change is in-tree with no regressions introduced. So, I don't think we should double check this change. My change simply define minItem constraint to interconnect-names which is already existing on interconnects. -Kuldeep
