> > > You cover this specific dependencies with inline ifdefs, but you > > > lose the CONFIG_OF depends by dropping it, and there are no such > > > checks in the probe routine. Assumptions of OF are not limited to probe in > this driver. > > > > > > While I would like to see this assumption properly abstracted, the > > > most expedient/immediate fix is probably to add a depends on OF above. > > > > Andriy, how do you think? > > > > How about > > depends on OF_GPIO || MFD_GPIO_DWAPB, or depends on OF_GPIO || > > MFD_INTEL_QUARK_I2C_GPIO? > > > > Upon closer inspection, I think my concern is invalid. the OF header already > tests for CONFIG_OF and provides no-op / -ENOSYS (tsk tsk) alternatives. So > long as you can compile with "#CONFIG_OF is not set" as it is, then I withdraw > my comment. Yes, it can be compiled with "#CONFIG_OF is not set" and "#CONFIG_OF_GPIO is not set" > > Sorry for the noise. > > -- > Darren Hart > Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
