Hi Jae
> -----Original Message-----
> From: Jae Hyun Yoo <quic_jaehyoo@xxxxxxxxxxx>
> Sent: Thursday, March 24, 2022 9:49 PM
> To: Howard Chiu <howard_chiu@xxxxxxxxxxxxxx>; robh+dt@xxxxxxxxxx; Joel
> Stanley <joel@xxxxxxxxx>; andrew@xxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-aspeed@xxxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v1 1/3] ARM: dts: aspeed: Add video engine
>
> Hi Howard,
>
> On 3/24/2022 12:27 AM, Howard Chiu wrote:
> > The ast2600 SoC has an embedded video engine
> >
> > Signed-off-by: Howard Chiu <howard_chiu@xxxxxxxxxxxxxx>
> > ---
> > arch/arm/boot/dts/aspeed-g6.dtsi | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi
> > b/arch/arm/boot/dts/aspeed-g6.dtsi
> > index c32e87fad4dc..41d5087f7d92 100644
> > --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> > +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> > @@ -389,6 +389,17 @@ sbc: secure-boot-controller@1e6f2000 {
> > reg = <0x1e6f2000 0x1000>;
> > };
> >
> > + video: video@1e700000 {
> > + compatible = "aspeed,ast2600-video-engine";
> > + reg = <0x1e700000 0x1000>;
> > + clocks = <&syscon ASPEED_CLK_GATE_VCLK>,
> > + <&syscon ASPEED_CLK_GATE_ECLK>;
> > + clock-names = "vclk", "eclk";
> > + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> > + resets = <&syscon ASPEED_RESET_VIDEO>;
>
> Video engine reset is handled by clk-ast2600.c so you don't need to add
> 'resets'.
>
> > + status = "disabled";
> > + };
> > +
>
> This node was already added back by this change.
> https://lore.kernel.org/all/CACPK8XfPPLoS=mhwbAHY4EfVad=1_dnhB+gaHBjPj
> 1wWbWE4gg@xxxxxxxxxxxxxx/
>
Thanks for info, the next patchset won't include this.
> Cheers,
>
> -Jae
>
> > gpio0: gpio@1e780000 {
> > #gpio-cells = <2>;
> > gpio-controller;
