On 3/24/2022 5:10 PM, Andrew Lunn wrote:
The clock delay I mentioned is added into u-boot bootloader in a patch I'm currently trying to submit. https://lore.kernel.org/all/20220324165530.359668-1-quic_jaehyoo@xxxxxxxxxxx/Do you mean this: +&scu { + mac0-clk-delay = <0x1d 0x1c + 0x10 0x17 + 0x10 0x17>; + mac1-clk-delay = <0x1d 0x10 + 0x10 0x10 + 0x10 0x10>; + mac2-clk-delay = <0x0a 0x04 + 0x08 0x04 + 0x08 0x04>; + mac3-clk-delay = <0x0a 0x04 + 0x08 0x04 + 0x08 0x04>; So the MAC is adding the delay. In that case, setting phy-mode to rgmii is O.K, but it would be nice to add a comment in DT that the bootloader is setting up the MAC to insert the delay.
Right. It would be better with the comment. I'll add the comment in v2. Thanks for your suggestion! -Jae
