Hi, Corentin: I've applied Jason's series [1] to my tree [2], does that series fix your problem? [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=621899 [2] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes Regards, Chun-Kuang. Corentin Labbe <clabbe@xxxxxxxxxxxx> 於 2022年3月24日 週四 下午11:27寫道: > > make dt_binding_check fail on lot of mediatek bindings due to missing > includes. > > Signed-off-by: Corentin Labbe <clabbe@xxxxxxxxxxxx> > --- > 2 files remains to be fixed, but their examples use some variable undefined, so I cannot do anything: > - display/mediatek/mediatek,ethdr.yaml > - display/mediatek/mediatek,merge.yaml > > .../display/mediatek/mediatek,aal.yaml | 4 + > .../display/mediatek/mediatek,ccorr.yaml | 4 + > .../display/mediatek/mediatek,color.yaml | 4 + > .../display/mediatek/mediatek,dither.yaml | 4 + > .../display/mediatek/mediatek,dsc.yaml | 4 + > .../display/mediatek/mediatek,gamma.yaml | 4 + > .../display/mediatek/mediatek,mutex.yaml | 4 + > .../display/mediatek/mediatek,od.yaml | 1 + > .../display/mediatek/mediatek,ovl-2l.yaml | 5 + > .../display/mediatek/mediatek,ovl.yaml | 5 + > .../display/mediatek/mediatek,postmask.yaml | 4 + > .../display/mediatek/mediatek,rdma.yaml | 5 + > .../display/mediatek/mediatek,split.yaml | 3 + > .../display/mediatek/mediatek,ufoe.yaml | 3 + > .../display/mediatek/mediatek,wdma.yaml | 5 + > 17 files changed, 59 insertions(+), 257 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml > index 225f9dd726d2..63755d4d21d7 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml > @@ -66,6 +66,10 @@ additionalProperties: false > > examples: > - | > + #include <dt-bindings/clock/mt8173-clk.h> > + #include <dt-bindings/gce/mt8173-gce.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/power/mt8173-power.h> > > aal@14015000 { > compatible = "mediatek,mt8173-disp-aal"; > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml > index 6894b6999412..b32355b32dfa 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml > @@ -65,6 +65,10 @@ additionalProperties: false > > examples: > - | > + #include <dt-bindings/clock/mt8183-clk.h> > + #include <dt-bindings/gce/mt8183-gce.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/power/mt8183-power.h> > > ccorr0: ccorr@1400f000 { > compatible = "mediatek,mt8183-disp-ccorr"; > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml > index bc83155b3b4c..ffdef0b30de8 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml > @@ -75,6 +75,10 @@ additionalProperties: false > > examples: > - | > + #include <dt-bindings/clock/mt8173-clk.h> > + #include <dt-bindings/gce/mt8173-gce.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/power/mt8173-power.h> > > color0: color@14013000 { > compatible = "mediatek,mt8173-disp-color"; > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml > index 9d89297f5f1d..7ac58022a2ed 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml > @@ -65,6 +65,10 @@ additionalProperties: false > > examples: > - | > + #include <dt-bindings/clock/mt8183-clk.h> > + #include <dt-bindings/gce/mt8183-gce.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/power/mt8183-power.h> > > dither0: dither@14012000 { > compatible = "mediatek,mt8183-disp-dither"; > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsc.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsc.yaml > index 1ec083eff824..1ab30b0efffe 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsc.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsc.yaml > @@ -60,6 +60,10 @@ additionalProperties: false > > examples: > - | > + #include <dt-bindings/clock/mt8195-clk.h> > + #include <dt-bindings/gce/mt8195-gce.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/power/mt8195-power.h> > > dsc0: disp_dsc_wrap@1c009000 { > compatible = "mediatek,mt8195-disp-dsc"; > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml > index 247baad147b3..4f8ba492dc0a 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml > @@ -66,6 +66,10 @@ additionalProperties: false > > examples: > - | > + #include <dt-bindings/clock/mt8173-clk.h> > + #include <dt-bindings/gce/mt8173-gce.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/power/mt8173-power.h> > > gamma@14016000 { > compatible = "mediatek,mt8173-disp-gamma"; > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,mutex.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,mutex.yaml > index 6eca525eced0..ad3a69d1254c 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,mutex.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,mutex.yaml > @@ -71,6 +71,10 @@ additionalProperties: false > > examples: > - | > + #include <dt-bindings/clock/mt8173-clk.h> > + #include <dt-bindings/gce/mt8173-gce.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/power/mt8173-power.h> > > mutex: mutex@14020000 { > compatible = "mediatek,mt8173-disp-mutex"; > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,od.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,od.yaml > index 7519db315217..1f92566ff5ed 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,od.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,od.yaml > @@ -45,6 +45,7 @@ additionalProperties: false > > examples: > - | > + #include <dt-bindings/clock/mt8173-clk.h> > > od@14023000 { > compatible = "mediatek,mt8173-disp-od"; > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl-2l.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl-2l.yaml > index e3cef99d0f98..e810e152404a 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl-2l.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl-2l.yaml > @@ -66,6 +66,11 @@ additionalProperties: false > > examples: > - | > + #include <dt-bindings/clock/mt8183-clk.h> > + #include <dt-bindings/gce/mt8183-gce.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/memory/mt8183-larb-port.h> > + #include <dt-bindings/power/mt8183-power.h> > > ovl_2l0: ovl@14009000 { > compatible = "mediatek,mt8183-disp-ovl-2l"; > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml > index 93d5c68a2dbd..14673f979edc 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml > @@ -81,6 +81,11 @@ additionalProperties: false > > examples: > - | > + #include <dt-bindings/clock/mt8173-clk.h> > + #include <dt-bindings/gce/mt8173-gce.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/memory/mt8173-larb-port.h> > + #include <dt-bindings/power/mt8173-power.h> > > ovl0: ovl@1400c000 { > compatible = "mediatek,mt8173-disp-ovl"; > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,postmask.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,postmask.yaml > index 6ac1da2e8871..d0d45d1e4f15 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,postmask.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,postmask.yaml > @@ -58,6 +58,10 @@ additionalProperties: false > > examples: > - | > + #include <dt-bindings/clock/mt8192-clk.h> > + #include <dt-bindings/gce/mt8192-gce.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/power/mt8192-power.h> > > postmask0: postmask@1400d000 { > compatible = "mediatek,mt8192-disp-postmask"; > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml > index b56e22fbcd52..2265fef6a795 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml > @@ -94,6 +94,11 @@ additionalProperties: false > > examples: > - | > + #include <dt-bindings/clock/mt8173-clk.h> > + #include <dt-bindings/gce/mt8173-gce.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/memory/mt8173-larb-port.h> > + #include <dt-bindings/power/mt8173-power.h> > > rdma0: rdma@1400e000 { > compatible = "mediatek,mt8173-disp-rdma"; > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml > index 4f08e89c1067..83e6cb40ba7c 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml > @@ -49,6 +49,9 @@ additionalProperties: false > > examples: > - | > + #include <dt-bindings/clock/mt8173-clk.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/power/mt8173-power.h> > > split0: split@14018000 { > compatible = "mediatek,mt8173-disp-split"; > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.yaml > index 6e8748529e73..69cddc2ee531 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.yaml > @@ -51,6 +51,9 @@ additionalProperties: false > > examples: > - | > + #include <dt-bindings/clock/mt8173-clk.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/power/mt8173-power.h> > > ufoe@1401a000 { > compatible = "mediatek,mt8173-disp-ufoe"; > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.yaml > index f9f00a518edf..60e9f890ebf1 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.yaml > @@ -64,6 +64,11 @@ additionalProperties: false > > examples: > - | > + #include <dt-bindings/clock/mt8173-clk.h> > + #include <dt-bindings/gce/mt8173-gce.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/memory/mt8173-larb-port.h> > + #include <dt-bindings/power/mt8173-power.h> > > wdma0: wdma@14011000 { > compatible = "mediatek,mt8173-disp-wdma"; > -- > 2.34.1 >