Hi Doug, On Thu, Mar 24, 2022 at 11:27:46AM -0700, Doug Anderson wrote: > Hi, > > On Thu, Mar 24, 2022 at 11:14 AM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote: > > > > Add support for the AUO B133UAN01 13.3" WUXGA panel. > > > > Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> > > --- > > output of edid-decode: > > > > Block 0, Base EDID: > > EDID Structure Version & Revision: 1.4 > > Vendor & Product Identification: > > Manufacturer: AUO > > Model: 34196 > > Made in: 2020 > > Basic Display Parameters & Features: > > Digital display > > Bits per primary color channel: 8 > > DisplayPort interface > > Maximum image size: 29 cm x 18 cm > > Gamma: 2.20 > > Supported color formats: RGB 4:4:4 > > First detailed timing includes the native pixel format and preferred refresh rate > > Color Characteristics: > > Red : 0.6513, 0.3271 > > Green: 0.2900, 0.6279 > > Blue : 0.1503, 0.0517 > > White: 0.3134, 0.3291 > > Established Timings I & II: none > > Standard Timings: none > > Detailed Timing Descriptors: > > DTD 1: 1920x1200 60.026 Hz 8:5 74.192 kHz 156.100 MHz (286 mm x 178 mm) > > Hfront 16 Hsync 16 Hback 152 Hpol N > > Vfront 3 Vsync 14 Vback 19 Vpol N > > Manufacturer-Specified Display Descriptor (0x0f): 00 0f 00 00 00 00 00 00 00 00 00 00 00 00 00 20 '............... ' > > Alphanumeric Data String: 'AUO' > > Alphanumeric Data String: 'B133UAN01.0 ' > > > > drivers/gpu/drm/panel/panel-edp.c | 32 +++++++++++++++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > I can review this patch and it can be landed if you really need it, > but I'd prefer not to. Instead I'd rather see the panel added to > _just_ the "edp_panels" structure. That maps the panel ID to the > delays. If we do it that way: > > 1. We don't need the binding. > > 2. We don't need to hardcode the mode in this file. > > 3. We support second sourcing the panel. > > 4. We simplify our device tree files. > > > Let me know if we can just go that way. If we really have a reason to > support the old hardcoded mode we can land something like this but I'd > rather avoid it if possible. > > Also: note that even if we land this, adding the entry to the > "edp_panels" structure would help future-proof us a bit. Thanks for your suggestion, it seems it should be possible to support the panel as you described, which I agree is preferable. I'll send a new version without the binding and the hardcoded mode.
