On 24/03/2022 07:22, Cixi Geng wrote:
> Krzysztof Kozlowski <krzk@xxxxxxxxxx> 于2022年3月20日周日 22:50写道：
>>
>> On 11/03/2022 17:46, Cixi Geng wrote:
>>> From: Cixi Geng <cixi.geng1@xxxxxxxxxx>
>>>
>>> sprd,ump9620-adc is one variant of sc27xx series, add ump9620 in
>>> dtbindings.
>>>
>>> Signed-off-by: Chunyan Zhang <zhang.lyra@xxxxxxxxx>
>>> Signed-off-by: Cixi Geng <cixi.geng1@xxxxxxxxxx>
>>> ---
>>> .../bindings/iio/adc/sprd,sc2720-adc.yaml | 30 +++++++++++++++++--
>>> 1 file changed, 27 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml b/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml
>>> index caa3ee0b4b8c..331b08fb1761 100644
>>> --- a/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml
>>> +++ b/Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.yaml
>>> @@ -20,6 +20,7 @@ properties:
>>> - sprd,sc2723-adc
>>> - sprd,sc2730-adc
>>> - sprd,sc2731-adc
>>> + - sprd,ump9620-adc
>>>
>>> reg:
>>> maxItems: 1
>>> @@ -37,9 +38,32 @@ properties:
>>> maxItems: 2
>>>
>>> nvmem-cell-names:
>>> - items:
>>> - - const: big_scale_calib
>>> - - const: small_scale_calib
>>
>> Please test your changes with dt_binding_check and dtbs_check. Your
>> change looks not complete - you have still nvmem-cells = 2.
>>
> Hi Krzysztof
> I test all is PASS on my local. could you tell how did you test?
> my_logs:
> cixi.geng1@tj10039pcu:~/upsteatming/linux$ make DT_CHECKER_FLAGS=-m
> dt_binding_check &>dt_check.log
> cixi.geng1@tj10039pcu:~/upsteatming/linux$ cat dt_check.log |grep sprd,sc2720
> DTEX Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.example.dts
> DTC Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.example.dt.yaml
> CHECK Documentation/devicetree/bindings/iio/adc/sprd,sc2720-adc.example.dt.yaml
> cixi.geng1@tj10039pcu:~/upsteatming/linux$ tuxmake -C ${kernel_src} -b
> ${topdir}/obj/gcc -o ${topdir}/dist/gcc -a $ARCH -t gcc -K
> CONFIG_ARCH_${PLAT}=y -K CONFIG_MFD_SC27XX_PMIC=y -K
> CONFIG_SC27XX_ADC=y
>
The method is correct, just please test sprd,ump9620-adc (either in
example in the binding or your DTS with `make dtbs_check
DT_SCHEMA_FILES=sprd,sc2720-adc.yaml).
Best regards,
Krzysztof
