On Mi, 2022-03-23 at 17:21 +0100, Clément Léger wrote: > Le Wed, 23 Mar 2022 16:29:41 +0100, > Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> a écrit : > > > On Mi, 2022-03-23 at 10:50 +0100, Clément Léger wrote: > > [...] > > > diff --git a/drivers/reset/core.c b/drivers/reset/core.c > > > index 61e688882643..f014da03b7c1 100644 > > > --- a/drivers/reset/core.c > > > +++ b/drivers/reset/core.c > > > @@ -4,6 +4,7 @@ > > > * > > > * Copyright 2013 Philipp Zabel, Pengutronix > > > */ > > > +#include <linux/acpi.h> > > > #include <linux/atomic.h> > > > #include <linux/device.h> > > > #include <linux/err.h> > > > @@ -70,26 +71,49 @@ static const char *rcdev_name(struct > > > reset_controller_dev *rcdev) > > > if (rcdev->of_node) > > > return rcdev->of_node->full_name; > > > > Could the above be removed, since reset_controller_register() set > > rcdev->fwnode to of_fwnode_handle(rcdev->of_node) earlier? > > Yes, this should work in all cases, the only difference is that > fwnode_get_name() returns the basename of the of_node full_name > field. > This is potentially a change from what was displayed before. If you are > ok with that, I'll drop these lines. Yes, that should be fine. rcdev_name() is currently only used in warnings that let driver developers know which reset controller they used incorrectly. regards Philipp
