Dear Rob, Sorry for the failings. "snps,txpbl"/"snps,rxpbl" are limited to enum [2,4,8] in snps,dwmac.yaml, but the hardware allows 1,2,4,8,16 or 32 according to datasheet. I'll submit another patch to modify enum in snps,dwmac.yaml. Regards! Biao On Wed, 2022-03-23 at 09:00 -0500, Rob Herring wrote: > On Mon, Mar 14, 2022 at 2:57 AM Biao Huang <biao.huang@xxxxxxxxxxxx> > wrote: > > > > Convert mediatek-dwmac to DT schema, and delete old mediatek- > > dwmac.txt. > > And there are some changes in .yaml than .txt, others almost keep > > the same: > > 1. compatible "const: snps,dwmac-4.20". > > 2. delete "snps,reset-active-low;" in example, since driver > > remove this > > property long ago. > > 3. add "snps,reset-delay-us = <0 10000 10000>" in example. > > 4. the example is for rgmii interface, keep related properties > > only. > > > > Signed-off-by: Biao Huang <biao.huang@xxxxxxxxxxxx> > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > --- > > .../bindings/net/mediatek-dwmac.txt | 91 ---------- > > .../bindings/net/mediatek-dwmac.yaml | 155 > > ++++++++++++++++++ > > 2 files changed, 155 insertions(+), 91 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/net/mediatek- > > dwmac.txt > > create mode 100644 Documentation/devicetree/bindings/net/mediatek- > > dwmac.yaml > > Now failing in linux-next: > > /builds/robherring/linux- > dt/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: > ethernet@1101c000: snps,txpbl:0:0: 1 is not one of [2, 4, 8] > From schema: /builds/robherring/linux- > dt/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > /builds/robherring/linux- > dt/Documentation/devicetree/bindings/net/mediatek-dwmac.example.dtb: > ethernet@1101c000: snps,rxpbl:0:0: 1 is not one of [2, 4, 8] > From schema: /builds/robherring/linux- > dt/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > > Rob
