Hi Krzysztof, Thanks for the review. On 23 March 2022 10:44, Krzysztof Kozlowski wrote: > On 21/03/2022 16:42, Phil Edworthy wrote: > > Define RZ/V2M (R9A09G011) Clock Pulse Generator core clocks, module > clock > > outputs (CPG_CLK_ON* registers), and reset definitions (CPG_RST_* > > registers) in Section 48.5 ("Register Description") of the RZ/V2M > Hardware > > User's Manual (Rev. 1.10, Sep. 2021). > > > > Signed-off-by: Phil Edworthy <phil.edworthy@xxxxxxxxxxx> > > Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > --- > > include/dt-bindings/clock/r9a09g011-cpg.h | 337 ++++++++++++++++++++++ > > 1 file changed, 337 insertions(+) > > create mode 100644 include/dt-bindings/clock/r9a09g011-cpg.h > > > > diff --git a/include/dt-bindings/clock/r9a09g011-cpg.h b/include/dt- > bindings/clock/r9a09g011-cpg.h > > new file mode 100644 > > index 000000000000..b88dbb0d8c49 > > --- /dev/null > > +++ b/include/dt-bindings/clock/r9a09g011-cpg.h > > @@ -0,0 +1,337 @@ > > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > + * > > + * Copyright (C) 2022 Renesas Electronics Corp. > > + */ > > +#ifndef __DT_BINDINGS_CLOCK_R9A09G011_CPG_H__ > > +#define __DT_BINDINGS_CLOCK_R9A09G011_CPG_H__ > > + > > +#include <dt-bindings/clock/renesas-cpg-mssr.h> > > Include only headers which you use here. Do you use it directly here? Ah, it was just used by my dtsi for CPG_CORE and CPG_MOD definitions. I'll moved the include to the dtsi. Thanks Phil