Le Tue, Mar 22, 2022 at 11:25:25AM +0000, Robin Murphy a écrit : > On 2022-03-21 20:07, Corentin Labbe wrote: > > The hardware does not handle 0 size length request, let's add a > > fallback. > > Furthermore fallback will be used for all unaligned case the hardware > > cannot handle. > > > > Fixes: ce0183cb6464b ("crypto: rockchip - switch to skcipher API") > > Signed-off-by: Corentin Labbe <clabbe@xxxxxxxxxxxx> > > --- > > drivers/crypto/Kconfig | 4 + > > drivers/crypto/rockchip/rk3288_crypto.h | 2 + > > .../crypto/rockchip/rk3288_crypto_skcipher.c | 105 +++++++++++++++--- > > 3 files changed, 98 insertions(+), 13 deletions(-) > > > > diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig > > index 7b2d138bc83e..84ab14afcbd9 100644 > > --- a/drivers/crypto/Kconfig > > +++ b/drivers/crypto/Kconfig > > @@ -784,6 +784,10 @@ config CRYPTO_DEV_IMGTEC_HASH > > config CRYPTO_DEV_ROCKCHIP > > tristate "Rockchip's Cryptographic Engine driver" > > depends on OF && ARCH_ROCKCHIP > > + depends on PM > > This appears to belong to patch #13 rather than this one. > Hello Yes this is an error, I will move it this line on the right patch. > My initial thought was that it probably shouldn't be something for > random consumers to care about at all, but there do seem to be a handful > of other drivers relying on pm_runtime_resume to enable their clocks, so > I guess maybe it's an acceptable idiom :/ > Depending on PM made the driver easier to understand (no more if PM/if not PM). And anyway, since it's embedded device, PM should be always enabled. Thanks