> On Tue, Mar 22, 2022 at 7:17 AM Qin Jian <qinjian@xxxxxxxxxxx> wrote: > > > > Add generic Sunplus SP7021 based board defconfig > > > > Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx> > > Signed-off-by: Qin Jian <qinjian@xxxxxxxxxxx> > > I don't think I ever replied with 'Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>' > to this patch. While I did review it in version 5, you never seem to have > replied to my questions there. > > It was a while ago though, so I don't remember the details, if we did > conclude the review, can you link to the lore.kernel.org thread in > the next version? Please also check the other patches on which > you added a 'Reviewed-by' tag from someone to ensure that they > actually provided that tag, rather than just providing review comments. > > Arnd In patch 6, I fixed all your comments. I got a reply from you: https://lore.kernel.org/all/CAK8P3a1Doh8GY9iFZsvmd6wASHoPqyR+roXx0G5XidnmHNkGaA@xxxxxxxxxxxxxx/ > This looks all good to me now, it just needs a review for the clk, > reset and irqchip drivers. ... If these not means you reviewed, I'll remove your review-tag.