Hi Krzysztof, Thanks for your comment. First of all, which "generic wakeup-source property" do you mean? Could you give an example? I find "wakeup-source" property in several binding files. Are you pointing to this? As my understanding, there is no standard naming rule about the property of each driver right? Currently, there's no virtio-mmio driver using this. Anyway, I can modify my patch, if you prefer "wakeup-source". Regards, Minghao On Fri, Mar 18, 2022 at 02:40:29PM +0100, Krzysztof Kozlowski wrote: > On 18/03/2022 03:10, Minghao Xue wrote: > > Hi Jean and folks, > > This is just an optional flag which could be used on an embedded system. > > For example, if we want to use an virtio-input device as a virtual power > > key to wake up the virtual machine, we can set this flag in the device > > tree. > > Currently, virio-mmio driver does not implement suspend/resume > > callback(maybe no need). So we want to check this flag and call > > enable_irq_wake() accordingly in vm_find_vqs(). > > There is a generic wakeup-source property. How is this one different > that you need a separate one? > > > Best regards, > Krzysztof
