> > The use case is generic i.e. require separate handle to internal SGMII > > and external Phy so would prefer this new DT convention is > > standardized or we discuss possible approaches on how to handle > > both phys and not add it as vendor specific property in the first > > place. > > IMO, you should use 'phys' for the internal PCS phy. That's aligned with > other uses like PCIe, SATA, etc. (there is phy h/w that will do PCS, > PCIe, SATA). 'phy-handle' is for the ethernet PHY. We need to be careful here, because the PCS can have a well defined set of registers accessible over MDIO. Generic PHY has no infrastructure for that, it is all inside phylink which implements the pcs registers which are part of 802.3. I also wonder if a PCS might actually have a generic PHY embedded in it to provide its lower interface? Andrew