On Tuesday 09 September 2014 17:42:41 Alban Bedel wrote:
> +config PWM_LPC32XX_MOTOR
> + tristate "LPC32xx Motor PWM support"
> + depends on ARCH_LPC32XX
> + help
> + Generic PWM framework driver for LPC32xx motor PWM. The LPC32xx SOC
> + has one motor PWM controllers.
> +
> + To compile this driver as a module, choose M here: the module
> + will be called pwm-lpc32xx-motor.
> +
Can you change the dependency to ARCH_LPC32XX || COMPILE_TEST and
add explicit dependencies for the subsystems the driver depends
on (pwm and clk, I guess)? That would give us better build-time
coverage with allmodconfig.
> + /* Write to limit register -> period */
> + __raw_writel(period, lpc32xx->base + MCLIM_REG_OFFSET(pwm));
> +
> + /* Write to match register -> duty */
> + __raw_writel(period - duty, lpc32xx->base + MCMAT_REG_OFFSET(pwm));
Please don't use __raw_{writel,readl} in driver, and change that to use
readl_relaxed()/writel_relaxed().
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
