On Fri, 11 Mar 2022 17:15:59 +0100 michael.srba@xxxxxxxxx wrote: > From: Michael Srba <Michael.Srba@xxxxxxxxx> > > ICM-20608-D differs from the other ICM-20608 variants by having > a DMP (Digital Motion Processor) core tacked on. > Despite having a different WHOAMI register, this variant is > completely interchangeable with the other ICM-20608 variants > by simply pretending the DMP core doesn't exist. > > Signed-off-by: Michael Srba <Michael.Srba@xxxxxxxxx> > --- > changelog: > - v2: require specifying "invensense,icm20608" as a fallback compatible Apologies that I joined the thread for v1 late, but no. That doesn't work. If the older driver before the new ID is present with this binding it won't probe because of the WHOAMI value difference so it's not compatible. I'm fine with the v1 version. > --- > .../bindings/iio/imu/invensense,mpu6050.yaml | 34 +++++++++++-------- > 1 file changed, 19 insertions(+), 15 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml > index d69595a524c1..dbd214e7baba 100644 > --- a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml > +++ b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml > @@ -14,21 +14,25 @@ description: | > > properties: > compatible: > - enum: > - - invensense,iam20680 > - - invensense,icm20608 > - - invensense,icm20609 > - - invensense,icm20689 > - - invensense,icm20602 > - - invensense,icm20690 > - - invensense,mpu6000 > - - invensense,mpu6050 > - - invensense,mpu6500 > - - invensense,mpu6515 > - - invensense,mpu6880 > - - invensense,mpu9150 > - - invensense,mpu9250 > - - invensense,mpu9255 > + oneOf: > + - enum: > + - invensense,iam20680 > + - invensense,icm20608 > + - invensense,icm20609 > + - invensense,icm20689 > + - invensense,icm20602 > + - invensense,icm20690 > + - invensense,mpu6000 > + - invensense,mpu6050 > + - invensense,mpu6500 > + - invensense,mpu6515 > + - invensense,mpu6880 > + - invensense,mpu9150 > + - invensense,mpu9250 > + - invensense,mpu9255 > + - items: > + - const: invensense,icm20608d > + - const: invensense,icm20608 > > reg: > maxItems: 1
