Hi Krzysztof, > Subject: Re: [PATCH] arm64: dts: imx8mp: add ddr controller node to support > EDAC on imx8mp > > On 18/03/2022 12:35, Sherry Sun wrote: > > i.MX8MP use synopsys V3.70a ddr controller IP, so add edac support for > > i.MX8MP based on "snps,ddrc-3.80a" synopsys edac driver. > > One more point - I think it might be worth to add dedicated compatible for > v3.70, as it is clearly a different version (with fallback to v3.80a). Thanks for the review, I have check the V3.70a and V3.80a Synopsys ddr controller databook, there is no difference for the inline ECC part. So do you think we still need to add a new compatible for V3.70a even the EDAC driver operation is totally same with V3.80a? Best regards Sherry > > > Best regards, > Krzysztof