On Thu, 2022-03-17 at 18:02 +0800, Andy Chiu wrote:
> loop in: radhey.shyam.pandey@xxxxxxxxxx
>
>
> On Thu, Mar 17, 2022 at 5:21 PM Andy Chiu <andy.chiu@xxxxxxxxxx> wrote:
> > Document the new pcs-handle attribute to support connecting to an
> > external PHY in SGMII or 1000Base-X modes through the internal PCS/PMA
> > PHY.
> >
> > Signed-off-by: Andy Chiu <andy.chiu@xxxxxxxxxx>
> > Reviewed-by: Greentime Hu <greentime.hu@xxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/net/xilinx_axienet.txt | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/xilinx_axienet.txt
> > b/Documentation/devicetree/bindings/net/xilinx_axienet.txt
> > index b8e4894bc634..2a9a3a90eb63 100644
> > --- a/Documentation/devicetree/bindings/net/xilinx_axienet.txt
> > +++ b/Documentation/devicetree/bindings/net/xilinx_axienet.txt
> > @@ -68,6 +68,11 @@ Optional properties:
> > required through the core's MDIO interface (i.e. always,
> > unless the PHY is accessed through a different bus).
> >
> > + - pcs-handle: Phandle to the internal PCS/PMA PHY, if a fixed
> > external PHY
> > + is tied to it in SGMII or 1000Base-X modes. This is not
> > + required for SFP connection. The driver would use phy-
> > handle
> > + to reference the PCS/PMA PHY in such case.
> > +
I would say pcs-handle should be preferably used to point to the PCS/PMA in all
cases. phy-handle should be used for a fixed PHY downstream of the PCS/PMA if
one exists - using that for the PCS/PMA would be just for backward
compatibility with old device trees.
Might want a comment as such in the code as well, where it is retrieving phy-
handle for the PCS and pcs-handle is not present.
> > Example:
> > axi_ethernet_eth: ethernet@40c00000 {
> > compatible = "xlnx,axi-ethernet-1.00.a";
> > --
> > 2.34.1
> >
--
Robert Hancock
Senior Hardware Designer, Calian Advanced Technologies
www.calian.com
