On Thu, Mar 17, 2022 at 02:45:19PM +0700, Quan Nguyen wrote: > Added Dan as I have missed Dan's email address in the first place. > My apologize, > - Quan > > On 11/03/2022 13:58, Wolfram Sang wrote: > > On Thu, Mar 10, 2022 at 06:41:18PM +0700, Quan Nguyen wrote: > > > From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > > > > The copy_from_user() function returns the number of bytes remaining to > > > be copied but we should return -EFAULT here. > > > > > > Fixes: 501c25b59508 ("ipmi: ssif_bmc: Add SSIF BMC driver") > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > Signed-off-by: Corey Minyard <cminyard@xxxxxxxxxx> > > > Signed-off-by: Quan Nguyen <quan@xxxxxxxxxxxxxxxxxxxxxx> > > > > It is nice that you want to keep this patch seperate to give Dan > > credits, but I still think it should be merged into patch 1, so the > > initial driver is as flawless as it can be. You could give Dan still > > credits by mentioning him in the commit message IMO. Dan, would you be > > fine with this? Yes, that's no problem. Thanks! regards, dan carpenter