Hi Arnd, Thanks for reviewing :-) > > + phy = devm_phy_create(dev, NULL, match->data, NULL); > > + if (IS_ERR(phy)) { > > + dev_err(dev, "failed to create Display Port PHY\n"); > > + return PTR_ERR(phy); > > + } > > + > > There is only one entry in the match table, so it always points to > stih407_usb2_picophy_data. Do you have plans to add another set of > operations soon? Nope. > If not, just remove the .data pointer and hardcode the operations > in the devm_phy_create call. I've done as you suggest in v3 which I will send shortly. regards, Peter. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html