Quoting Gwendal Grignou (2022-03-15 10:30:38) > Add ability to set the precharge internal resistance from the device > tree. > > Signed-off-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx> > --- > drivers/iio/proximity/sx9324.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/proximity/sx9324.c b/drivers/iio/proximity/sx9324.c > index 1bef16437aa84..785af857b23a1 100644 > --- a/drivers/iio/proximity/sx9324.c > +++ b/drivers/iio/proximity/sx9324.c > @@ -70,7 +70,8 @@ > #define SX9324_REG_AFE_PH2 0x2a > #define SX9324_REG_AFE_PH3 0x2b > #define SX9324_REG_AFE_CTRL8 0x2c > -#define SX9324_REG_AFE_CTRL8_RESFILTN_4KOHM 0x02 > +#define SX9324_REG_AFE_CTRL8_RESFILTIN_4KOHM 0x02 > +#define SX9324_REG_AFE_CTRL8_RESFILTIN_MASK GENMASK(3, 0) > #define SX9324_REG_AFE_CTRL9 0x2d > #define SX9324_REG_AFE_CTRL9_AGAIN_1 0x08 > > @@ -781,7 +782,7 @@ static const struct sx_common_reg_default sx9324_default_regs[] = { > { SX9324_REG_AFE_PH2, 0x1a }, > { SX9324_REG_AFE_PH3, 0x16 }, > > - { SX9324_REG_AFE_CTRL8, SX9324_REG_AFE_CTRL8_RESFILTN_4KOHM }, > + { SX9324_REG_AFE_CTRL8, 0x10 | SX9324_REG_AFE_CTRL8_RESFILTIN_4KOHM }, Is this 0x10 an enable bit? So it wasn't being enabled before? Please make a define for the 0x10 value. > { SX9324_REG_AFE_CTRL9, SX9324_REG_AFE_CTRL9_AGAIN_1 }, > > { SX9324_REG_PROX_CTRL0, SX9324_REG_PROX_CTRL0_GAIN_1 |