> > +static struct platform_driver ac5_pinctrl_driver = { > > + .driver = { > > + .name = "ac5-pinctrl", > > + .of_match_table = of_match_ptr(ac5_pinctrl_of_match), > > of_match_ptr() does not look correct for OF-only platform. This should > complain in W=1 compile tests on !OF config. The Marvell family of SoC which this embedded SoC borrows HW blocks from can boot using ACPI. I doubt anybody would boot this particularly SoC using ACPI, but the drivers Chris copied probably do build !OF for when ACPI is in us. Andrew