On Tue, Mar 15, 2022 at 02:11:56AM +0000, Chris Packham wrote: > > On 15/03/22 13:24, Andrew Lunn wrote: > >> diff --git a/arch/arm64/boot/dts/marvell/armada-98dx2530.dtsi b/arch/arm64/boot/dts/marvell/armada-98dx2530.dtsi > >> new file mode 100644 > >> index 000000000000..ebe464b9ebd2 > >> --- /dev/null > >> +++ b/arch/arm64/boot/dts/marvell/armada-98dx2530.dtsi > >> @@ -0,0 +1,343 @@ > >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > >> +/* > >> + * Device Tree For AC5. > >> + * > >> + * Copyright (C) 2021 Marvell > >> + * > >> + */ > >> + > >> +/dts-v1/; > >> + memory@0 { > >> + device_type = "memory"; > >> + reg = <0x2 0x00000000 0x0 0x40000000>; > >> + // linux,usable-memory = <0x2 0x00000000 0x0 0x80000000>; > >> + }; > > Is the memory part of the SoC, or is it on the board? Normally it is > > on the board, so should be in the .dts file. But Apple M1 etc... > I also wasn't sure about linux,usable-memory. It's commented out so it's > obviously doing nothing but should it? No other in-tree dts files have it. Hi Chris I've no idea what it means. Maybe search the SDK and see if they have some code and what it does. But i would drop it. Andrew