On Tue, 2022-03-15 at 11:56 +0100, Krzysztof Kozlowski wrote: > On 14/03/2022 10:00, Rex-BC Chen wrote: > > Add aal binding for MT8183. > > > > Signed-off-by: Rex-BC Chen <rex-bc.chen@xxxxxxxxxxxx> > > Acked-by: Rob Herring <robh@xxxxxxxxxx> > > --- > > .../devicetree/bindings/display/mediatek/mediatek,aal.yaml | > > 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y > > aml > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y > > aml > > index 61f0ed1e388f..6c8c83988a24 100644 > > --- > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y > > aml > > +++ > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y > > aml > > @@ -23,6 +23,8 @@ properties: > > oneOf: > > - items: > > - const: mediatek,mt8173-disp-aal > > + - items: > > + - const: mediatek,mt8183-disp-aal > > Use enum in previous entry. This is weird setup to have items with > one > element and then duplicate it for another oneOf entry. > > > - items: > > - enum: > > - mediatek,mt2712-disp-aal > > > Best regards, > Krzysztof Hello Krzysztof, Thanks for your review. I will modify it in next version. BRs, Rex
