Re: [PATCH V2 2/6] dt-bindings: remoteproc: imx_rproc: support i.MX8QM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu 10 Mar 19:58 CST 2022, Peng Fan wrote:

> > Subject: Re: [PATCH V2 2/6] dt-bindings: remoteproc: imx_rproc: support
> > i.MX8QM
> > 
> > On Wed, Mar 09, 2022 at 06:21:14PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@xxxxxxx>
> > >
> > > Add i.MX8QM compatible
> > >
> > > There are two general purpose M4, so add reg property to indicate the
> > > id.
> > 
> > Where does the id come from? Is this just an index?
> 
> It is software use to identify which is m4_0 and which is m4_1,
> just an index.
> 

"reg" is supposed to represent some sort of identifier on the parent
bus, as such it doesn't seem to be the appropriate property to provide
an arbitrary 0 or 1 to identify which of the two m4s this is.

Regards,
Bjorn

> Thanks,
> Peng.
> 
> > 
> > >
> > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> > > ---
> > >  .../devicetree/bindings/remoteproc/fsl,imx-rproc.yaml         | 4
> > ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> > > b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> > > index f25c203dd2f9..41d366cff3cd 100644
> > > --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> > > +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> > > @@ -20,6 +20,7 @@ properties:
> > >        - fsl,imx8mn-cm7
> > >        - fsl,imx8mp-cm7
> > >        - fsl,imx8qxp-cm4
> > > +      - fsl,imx8qm-cm4
> > >        - fsl,imx8ulp-cm33
> > >        - fsl,imx7d-cm4
> > >        - fsl,imx7ulp-cm4
> > > @@ -68,6 +69,9 @@ properties:
> > >    power-domains:
> > >      maxItems: 8
> > >
> > > +  reg:
> > > +    maxItems: 1
> > > +
> > >    rsrc-id:
> > >      description:
> > >        This property is to specify the resource id of the remote
> > > processor in SoC
> > > --
> > > 2.30.0
> > >
> > >



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux