Il 13/03/22 16:10, Jiaxin Yu ha scritto:
Add support for mt8186 board with mt6366, da7219 and max98357. Signed-off-by: Jiaxin Yu <jiaxin.yu@xxxxxxxxxxxx> --- .../mt8186/mt8186-mt6366-da7219-max98357.c | 924 ++++++++++++++++++ 1 file changed, 924 insertions(+) create mode 100644 sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c
Hello Jiaxin, I see some duplication between this one and the mt6366-rt1019-rt5682s.... ....for this reason, I would propose to split out the MT6366 bits into a common file, something like mt8186-mt6366-common.c, as to reduce the duplication. If it is expected to see MT8186 machines with DA7219 or MAX98357, then it'd be a good idea to also do something about preventively commonizing these ones, like it is being done in ... MT8192, if I remember correctly. Regards, Angelo
