On 13/03/2022 13:38, Marek Vasut wrote: > The i.MX8MP contains two syscon registers which are responsible > for configuring the on-SoC DPI-to-LVDS serializer. Add DT binding > which represents this serializer as a bridge. > > Signed-off-by: Marek Vasut <marex@xxxxxxx> > Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > Cc: Maxime Ripard <maxime@xxxxxxxxxx> > Cc: Peng Fan <peng.fan@xxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Robby Cai <robby.cai@xxxxxxx> > Cc: Robert Foss <robert.foss@xxxxxxxxxx> > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx> > Cc: Thomas Zimmermann <tzimmermann@xxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > To: dri-devel@xxxxxxxxxxxxxxxxxxxxx > --- > .../bindings/display/bridge/nxp,ldb.yaml | 99 +++++++++++++++++++ > 1 file changed, 99 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/nxp,ldb.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/nxp,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/nxp,ldb.yaml > new file mode 100644 > index 0000000000000..a05dd05547836 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/nxp,ldb.yaml > @@ -0,0 +1,99 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/nxp,ldb.yaml# In title, description and commit msg you point this is specific to i.MX8M, so maybe reflect it in the file name as well. > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX8M DPI to LVDS bridge chip > + > +maintainers: > + - Marek Vasut <marex@xxxxxxx> > + > +description: | > + The i.MX8MP contains two syscon registers which are responsible > + for configuring the on-SoC DPI-to-LVDS serializer. This describes > + those registers as bridge within the DT. > + > +properties: > + compatible: > + items: > + - const: nxp,imx8mp-ldb No items. > + > + clocks: > + minItems: 1 maxItems > + > + clock-names: > + const: "ldb" No quotes > + > + syscon: You need a specific name with vendor prefix. > + $ref: /schemas/types.yaml#/definitions/phandle> + description: A phandle to media block controller. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: Video port for DPI input. > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: Video port for LVDS Channel-A output (panel or bridge). > + > + port@2: > + $ref: /schemas/graph.yaml#/properties/port > + description: Video port for LVDS Channel-B output (panel or bridge). > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - clocks > + - syscon > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/imx8mp-clock.h> > + > + lvds-ldb { Generic node name, so "bridge" or "display-bridge" > + #address-cells = <0>; > + #size-cells = <0>; Why do you need address and size cells? This will complain if you test your bindings with proper compatible. > + compatible = "fsl,imx8mp-ldb"; This does not look the same as documented here. Best regards, Krzysztof
