On 12/03/2022 00:51, Linus Walleij wrote: > This modifies the existing U-Blox GNSS bindings to reference > the common GNSS YAML bindings. > > Fixed an unrelated whitespace error while at it. > > Cc: devicetree@xxxxxxxxxxxxxxx > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > --- > .../devicetree/bindings/gnss/u-blox,neo-6m.yaml | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml > index 396101a223e7..5dffe722777f 100644 > --- a/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml > +++ b/Documentation/devicetree/bindings/gnss/u-blox,neo-6m.yaml > @@ -6,6 +6,9 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# > > title: U-blox GNSS Receiver Device Tree Bindings > > +allOf: > + - $ref: gnss-common.yaml# > + > maintainers: > - Johan Hovold <johan@xxxxxxxxxx> > > @@ -29,16 +32,13 @@ properties: > description: > > Main voltage regulator > > - timepulse-gpios: > - maxItems: 1 > - description: > > - Time pulse GPIO > + timepulse-gpios: true > > u-blox,extint-gpios: > maxItems: 1 > description: > > GPIO connected to the "external interrupt" input pin > - > + > v-bckp-supply: > description: > > Backup voltage regulator I propose to change additionalProperties->unevaluatedProperties and remove current-speed and timepulse-gpios. This way also new properties from gnss-common can be easily used. Best regards, Krzysztof
