On Fri, Mar 11, 2022 at 7:05 AM Paul Cercueil <paul@xxxxxxxxxxxxxxx> wrote: > > Hi Rob, > > Le jeu., mars 10 2022 at 16:30:26 -0600, Rob Herring <robh@xxxxxxxxxx> > a écrit : > > On Tue, Mar 08, 2022 at 02:06:43PM +0100, Christophe Branchereau > > wrote: > >> Add binding for the leadtek ltk035c5444t, which is a 640x480 > >> mipi-dbi over spi / 24-bit RGB panel based on the newvision > >> NV03052C chipset. > >> > >> It is found in the Anbernic RG350M mips handheld. > >> > >> Signed-off-by: Christophe Branchereau <cbranchereau@xxxxxxxxx> > >> --- > >> .../panel/leadtek,ltk035c5444t-spi.yaml | 59 > >> +++++++++++++++++++ > >> 1 file changed, 59 insertions(+) > >> create mode 100644 > >> Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi.yaml > > > > We have 18 SPI based panels already: > > > > $ git grep -i 'spi.* {' > > Documentation/devicetree/bindings/display/panel/ > > Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/ilitek,ili9163.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/lg,lg4573.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml: > > spi0 { > > Documentation/devicetree/bindings/display/panel/samsung,ld9040.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/samsung,lms380kf01.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/samsung,lms397kf04.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/samsung,s6d27a1.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/tpo,td.yaml: spi { > > Documentation/devicetree/bindings/display/panel/tpo,tpg110.yaml: > > spi { > > > > Most except for the Samsung ones look like they'd fit in our > > definition > > of 'simple panels' which primarily means 1 supply. > > > > So I think it is time for a panel-simple-spi.yaml binding to combine > > all > > these. But I'm not going to make the person adding the 19th case to do > > that, and this otherwise looks fine: > > > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > I actually thought you sent a patch for this already (I remember you > talking about it last a binding for a new SPI panel has been added). It was just adding spi-peripheral-props.yaml reference that I sent. > I will work on it next week - provided Cristophe's patch has been > merged before. Thanks! Rob