On 10/03/2022 20:52, nick.hawkins@xxxxxxx wrote: > From: Nick Hawkins <nick.hawkins@xxxxxxx> > > Add the hpe gxp watchdog timer binding hpe,gxp-wdt. > This will enable support for the HPE GXP Watchdog > > Signed-off-by: Nick Hawkins <nick.hawkins@xxxxxxx> > --- > .../bindings/watchdog/hpe,gxp-wdt.yaml | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml b/Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml > new file mode 100644 > index 000000000000..6044496b4968 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/hpe,gxp-wdt.yaml > @@ -0,0 +1,37 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/hpe,gxp-wdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HPE GXP Controlled Watchdog > + > +allOf: > + - $ref: "watchdog.yaml#" > + > +maintainers: > + - Nick Hawkins <nick.hawkins@xxxxxxx> > + - Jean-Marie Verdun <verdun@xxxxxxx> > + > +properties: > + compatible: > + const: hpe,gxp-wdt > + > + reg: > + items: > + - description: WDGRST register > + - description: WDGCS register Why are you mapping each register instead of entire address space? It won't scale if your new design comes with 10 registers... > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + watchdog0: watchdog@c0000090 { Skip the label. You also have there double space between label and node name. Best regards, Krzysztof
