Quoting Emil Renner Berthing (2022-01-26 09:39:47) > The problem is best illustrated by an example. Suppose a consumer wants > a 4MHz clock rate from a divider with a 10MHz parent. It would then > call > > clk_round_rate(clk, 4000000) > > which would call into our determine_rate() callback that correctly > rounds up and finds that a divisor of 3 gives the highest possible > frequency below the requested 4MHz and returns 10000000 / 3 = 3333333Hz. > > However the consumer would then call > > clk_set_rate(clk, 3333333) > > but since 3333333 doesn't divide 10000000 evenly our set_rate() callback > would again round the divisor up and set it to 4 which results in an > unnecessarily low rate of 2.5MHz. > > Fix it by using DIV_ROUND_CLOSEST in the set_rate() callback. > > Fixes: 4210be668a09 ("clk: starfive: Add JH7100 clock generator driver") > Signed-off-by: Emil Renner Berthing <kernel@xxxxxxxx> > --- Applied to clk-next