On Thu, Mar 10, 2022 at 06:26:02PM +0100, Krzysztof Kozlowski wrote: > On 10/03/2022 18:16, Jacopo Mondi wrote: > > Hi Krzysztof > > > > On Thu, Mar 10, 2022 at 03:29:24PM +0100, Krzysztof Kozlowski wrote: > >> On 10/03/2022 14:08, Jacopo Mondi wrote: > >>> Provide the bindings documentation for Omnivision OV5670 image sensor. > >>> > >>> Signed-off-by: Jacopo Mondi <jacopo@xxxxxxxxxx> > >>> --- > >>> .../devicetree/bindings/media/i2c/ov5670.yaml | 93 +++++++++++++++++++ > >> > >> Add the file to maintainers entry. > >> > > > > Right > > > >>> 1 file changed, 93 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5670.yaml > >>> > >>> diff --git a/Documentation/devicetree/bindings/media/i2c/ov5670.yaml b/Documentation/devicetree/bindings/media/i2c/ov5670.yaml > >>> new file mode 100644 > >>> index 000000000000..dc4a3297bf6f > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/media/i2c/ov5670.yaml > >> > >> Missing vendor prefix in file name. > >> > > > > Right x2 > > > >>> @@ -0,0 +1,93 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >>> +%YAML 1.2 > >>> +--- > >>> +$id: http://devicetree.org/schemas/media/i2c/ov5670.yaml# > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>> + > >>> +title: Omnivision OV5670 5 Megapixels raw image sensor > >>> + > >>> +maintainers: > >>> + - Jacopo Mondi <jacopo@xxxxxxxxxx> > >> > >> Please add also driver maintainer. > >> > > > > I never got what the policy was, if the maintainer entries here only > > refer to the binding file or to the driver too > > It is a person responsible for the bindings, so indeed it might not feed > existing maintainer. No need for a MAINTAINERS entry as get_maintainers.pl will pick it up from here. Rob
