On 10.03.2022 09:22, Krzysztof Kozlowski wrote: > On 09/03/2022 13:07, Sergiu Moga wrote: >> Add compatible strings list for SAMA7G5. >> >> Signed-off-by: Sergiu Moga <sergiu.moga@xxxxxxxxxxxxx> >> --- >> .../bindings/i2c/atmel,at91sam-i2c.yaml | 38 ++++++++++++------- >> 1 file changed, 24 insertions(+), 14 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml b/Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml >> index d4aadbbd1a11..661a679b98cf 100644 >> --- a/Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml >> +++ b/Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml >> @@ -16,10 +16,15 @@ allOf: >> properties: >> compatible: >> contains: >> - enum: >> - - atmel,sama5d4-i2c >> - - atmel,sama5d2-i2c >> - - microchip,sam9x60-i2c >> + oneOf: >> + - items: >> + - enum: >> + - atmel,sama5d4-i2c >> + - atmel,sama5d2-i2c >> + - microchip,sam9x60-i2c >> + - items: >> + - const: microchip,sama7g5-i2c >> + - const: microchip,sam9x60-i2c > This looks not needed, because it contains microchip,sam9x60-i2c which > is mentioned earlier. > Hmm, I might have misunderstood the functionality. I thought it would be stricter, having to match all the strings of that compatible. I guess something like this should be enough then? oneOf: - enum: - atmel,sama5d4-i2c - atmel,sama5d2-i2c - microchip,sam9x60-i2c - microchip,sama7g5-i2 Just adding the sama7g5 compatible seems to pass the check on my end. >> then: >> properties: >> i2c-sda-hold-time-ns: >> @@ -29,16 +34,21 @@ allOf: >> > Best regards, > Krzysztof Thank you for the feedback. Sergiu.
