On Fri, Feb 11, 2022 at 11:55:28AM +0000, Corentin Labbe wrote: > Converts watchdog/faraday,ftwdt010.txt to yaml. > This permits to detect missing properties like clocks and resets or > compatible like moxa,moxart-watchdog. > > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > Signed-off-by: Corentin Labbe <clabbe@xxxxxxxxxxxx> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> > Acked-by: Rob Herring <robh@xxxxxxxxxx> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> > --- > Changes since v1: > - Added myself as maintainer as requested by Linus > - Added $ref to watchdog.yaml > - Removed useless quotes > - Added blank lines between properties > - Removed timeout-secs as already provided by watchdog.yaml > > Change since v2: > - rewrite compatible section > > Changes since v3: > - Fix indent errors reported by yamllint > - Change additionalProperties to unevaluatedProperties > - Added timeout-secs in example > > .../bindings/watchdog/faraday,ftwdt010.txt | 22 ------ > .../bindings/watchdog/faraday,ftwdt010.yaml | 67 +++++++++++++++++++ > 2 files changed, 67 insertions(+), 22 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.txt > create mode 100644 Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.txt b/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.txt > deleted file mode 100644 > index 9ecdb502e605..000000000000 > --- a/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.txt > +++ /dev/null > @@ -1,22 +0,0 @@ > -Faraday Technology FTWDT010 watchdog > - > -This is an IP part from Faraday Technology found in the Gemini > -SoCs and others. > - > -Required properties: > -- compatible : must be one of > - "faraday,ftwdt010" > - "cortina,gemini-watchdog", "faraday,ftwdt010" > -- reg : shall contain base register location and length > -- interrupts : shall contain the interrupt for the watchdog > - > -Optional properties: > -- timeout-sec : the default watchdog timeout in seconds. > - > -Example: > - > -watchdog@41000000 { > - compatible = "faraday,ftwdt010"; > - reg = <0x41000000 0x1000>; > - interrupts = <3 IRQ_TYPE_LEVEL_HIGH>; > -}; > diff --git a/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml b/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml > new file mode 100644 > index 000000000000..ca9e1beff76b > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml > @@ -0,0 +1,67 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/faraday,ftwdt010.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Faraday Technology FTWDT010 watchdog > + > +maintainers: > + - Linus Walleij <linus.walleij@xxxxxxxxxx> > + - Corentin Labbe <clabbe@xxxxxxxxxxxx> > + > +description: | > + This is an IP part from Faraday Technology found in the Gemini > + SoCs and others. > + > +allOf: > + - $ref: "watchdog.yaml#" > + > +properties: > + compatible: > + oneOf: > + - const: faraday,ftwdt010 > + - items: > + - enum: > + - cortina,gemini-watchdog > + - moxa,moxart-watchdog > + - const: faraday,ftwdt010 > + > + reg: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: PCLK > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + watchdog@41000000 { > + compatible = "faraday,ftwdt010"; > + reg = <0x41000000 0x1000>; > + interrupts = <3 IRQ_TYPE_LEVEL_HIGH>; > + timeout-secs = <5>; > + }; > + - | > + watchdog: watchdog@98500000 { > + compatible = "moxa,moxart-watchdog", "faraday,ftwdt010"; > + reg = <0x98500000 0x10>; > + clocks = <&clk_apb>; > + clock-names = "PCLK"; > + }; > +...