On Mon, Sep 08, 2014 at 02:52:42PM +0100, Pavel Machek wrote: > Hi! > > > I would suggest we have two properties that describe the resistor's > > rating and whether or not there is a diode: > > > > trickle-resistor-ohms = <250> > > diode-connected; > > > > That's easy for a human to write and/or validate, we can easily extend > > it in future, requires no proliferation of macros, and describes the > > hardware rather than telling software what to do. > > > > The driver becomes a little more complicated, but gains sanity checking, > > which is a good thing. > > Certainly looks better than register bit defines. > > As rtc-bq32k has similar options, I'm interested, too. I believe we > should add > > trickle-charge-enable; > > (we may not want to charge at all), and I believe the diode should be > > disconnect-diode; > > ... With diode connected, charge is slower, and that probably should > be the default value. We don't want to give too much current in > default case. (bq32k has hard-coded resistor value for > diode/not-diode case). I agree that if one case is less likely to be problematic / damaging that should be the default. Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
