On Tue, Mar 08, 2022 at 07:03:15PM +0100, Krzysztof Kozlowski wrote: > On 08/03/2022 01:09, Brian Norris wrote: > Apologies for jumping in late in discussion, but how about moving it to > memory-controllers or interconnect directory? devfreq is Linux specific > and DMC sounds a lot like dynamic memory controller. Sure! Will do in v4. > > > > .../bindings/devfreq/rk3399_dmc.txt | 212 ------------- > > .../bindings/devfreq/rk3399_dmc.yaml | 294 ++++++++++++++++++ > > file name: > rockchip,rk3399-dmc.yaml Ack. > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/devfreq/rk3399_dmc.yaml > > + devfreq-events: > > + $ref: /schemas/types.yaml#/definitions/phandle-array > > + minItems: 1 > > + maxItems: 1 > > Rob previously asked about max, but it seems it is only one phandle, > right? Then the type - 'phandle'. Sure! Don't know why I didn't notice that. > > + rockchip,ddr3_odt: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: > > + When the DRAM type is DDR3, this parameter defines the DRAM side ODT > > + strength in ohms. Default value is 120. > > Here and in all other places - instead of describing default value in > description, just add "default: 120". Yep. Most of these properties are actually deprecated in the end, but doesn't hurt to use the facilities available. > Best regards, > Krzysztof Thanks for the reviews! I'll roll them all into v4 shortly. While I'm at it: I think I have Reviewed-by's for all the DT patches (except this one). Given it also touches Rockchip device trees, maybe this all needs to go through Heiko / linux-rockchip? Or if not, it'd be nice if Heiko spoke up to tell the devfreq maintainers instead. Regards, Brian
