On 07/03/2022 05:18, hammer hsieh wrote: > Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> 於 2022年3月4日 週五 > 下午11:01寫道： >> >> On 04/03/2022 07:20, Hammer Hsieh wrote: >>> Add bindings doc for Sunplus SoC PWM Driver >> >> You miss spaces in the subject. >> > > ok, will modify it. > >>> >>> Signed-off-by: Hammer Hsieh <hammerh0314@xxxxxxxxx> >>> --- >>> Changes in v2: >>> - Addressed all comments from Rob Herring. >>> modify author's mail match Signed-off-by. >>> - rebase kernel to 5.17 rc5 >>> >>> .../devicetree/bindings/pwm/pwm-sunplus.yaml | 40 ++++++++++++++++++++++ >>> MAINTAINERS | 5 +++ >>> 2 files changed, 45 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/pwm/pwm-sunplus.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-sunplus.yaml b/Documentation/devicetree/bindings/pwm/pwm-sunplus.yaml >>> new file mode 100644 >>> index 0000000..19fe5d5 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/pwm/pwm-sunplus.yaml >>> @@ -0,0 +1,40 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +# Copyright (C) Sunplus Co., Ltd. 2021 >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/pwm/pwm-sunplus.yaml# >> >> Is it going to be one binding for all Sunplus SoCs? Existing and future? >> > > yes, that was my first plan. > but not all sunplus SoCs use the same IP-based, > so I will change file name form 'pwm-sunplus.yaml' to > 'sunplus,sp7021-pwm.yaml' in next patch. Yes, that might be better approach, Best regards, Krzysztof
